Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck

Caolán McNamara <caolanm -AT- redhat.com>
Tue, 18 Jan 2011 14:55:06 +0000

On Tue, 2011-01-18 at 07:45 -0700, Tor Lillqvist wrote:

Or am I missing something...

Yes, we have a miserable trap of fall-through:


No, I did see the fall-through. But if pDlg is NULL (a bit earlier), we
 don't enter the block that contains the switch with the fall-through,
 where the other (hopefully only other possible) case does set pArgs


Those abstract dialogs should never fail in practice, nevertheless I've
added an early return for that case.

C.

Context

[Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Takeshi Abe
- [Libreoffice] [FIXED] Re: [PATCH] possible null-dereferencing found by cppcheck · Caolán McNamara
- Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Tor Lillqvist
  - Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Takeshi Abe
    - Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Tor Lillqvist
      - Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Takeshi Abe
        
        Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Tor Lillqvist
        
        Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Caolán McNamara
        
        Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Takeshi Abe
        
        [Libreoffice] [PUSHED] Re: [PATCH] possible null-dereferencing found by cppcheck · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.