Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hello,

Here is a patch for some cppcheck cleaning in ucb
Compiling was ok

I let this one :
[./source/ucp/tdoc/tdoc_content.hxx:69]: (warning) Member variable 'ContentProperties::m_eType' is not initialised in the constructor. because i don't know what to put by default (how to know that in this case ?).

Julien

(LGPLv3+ / MPL)


commit 58679f0ace3e80cf5302e1a92c083b0df6b34d2a
Author: Julien Nabet <serval2412@yahoo.fr>
Date:   Sun Jan 16 12:05:38 2011 +0100

    some cppcheck cleaning

diff --git a/ucb/source/sorter/sortresult.cxx b/ucb/source/sorter/sortresult.cxx
index 44c87c3..c18535d 100644
--- a/ucb/source/sorter/sortresult.cxx
+++ b/ucb/source/sorter/sortresult.cxx
@@ -938,7 +938,6 @@ Any SAL_CALL SortedResultSet::getPropertyValue( const OUString& PropertyName )
     }
     else if ( PropertyName.compareToAscii( "IsRowCountFinal" ) == 0 )
     {
-        sal_uInt32  nOrgCount = 0;
         sal_Bool    bOrgFinal = false;
         Any         aOrgRet;
 
@@ -952,6 +951,7 @@ Any SAL_CALL SortedResultSet::getPropertyValue( const OUString& PropertyName )
         {
             aOrgRet = Reference< XPropertySet >::query(mxOriginal)->
                 getPropertyValue( OUString(RTL_CONSTASCII_USTRINGPARAM("RowCount")) );
+            sal_uInt32  nOrgCount = 0;
             aOrgRet >>= nOrgCount;
             if ( nOrgCount == maS2O.Count() )
                 aRet <<= (sal_Bool) sal_True;
diff --git a/ucb/source/ucp/gio/gio_content.cxx b/ucb/source/ucp/gio/gio_content.cxx
index 80125c2..883fee5 100644
--- a/ucb/source/ucp/gio/gio_content.cxx
+++ b/ucb/source/ucp/gio/gio_content.cxx
@@ -314,7 +314,7 @@ class MountOperation
     GMainLoop *mpLoop;
     GMountOperation *mpAuthentication;
     GError *mpError;
-    static void Completed(GObject *source, GAsyncResult *res, gpointer user_data);
+    // TODO JULstatic void Completed(GObject *source, GAsyncResult *res, gpointer user_data);
 public:
     MountOperation(const uno::Reference< ucb::XCommandEnvironment >& xEnv);
     ~MountOperation();

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.