Re: [Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

Hi Robert, all!

Am Mittwoch, den 05.01.2011, 18:32 +0100 schrieb Robert Nagy:
> Oh well then Linux is broken, again. :)
>
> In gedit the icons are bigger than the small ones but not as huge
> as in LibreOffice.
> Here you can see (LO with small icons):
> http://blade2k.humppa.hu/2011-01-05-182917_1920x1080_scrot.png

Mmh, I'm unsure how much it helps to compare the different applications.
      * gedit is a native Gnome application and respects their desktop
        guidelines. --> 24x24 px toolbar icons, text below (always)
      * Firefox is a multi-platform application that (most of the time)
        respects platform specific rules --> 24x24 px toolbar icons, no
        text (which seems to be the default for Firefox)
      * LibreOffice is also multi-platform, but we care less about
        platform specific characteristics (mainly driven by saving
        effort ... for Windows, sharing toolbar and menu icons - no
        further comment on that) --> 16x16 px toolbar icons, no text

As said, our small toolbar icons are 16x16 px, the larger ones are 26x26
px. Thus, there is no way to perfectly align LibO/OOo to what the Gnome
Desktop defines/requires.

Moreover, one of our main problems is, that we do offer too many toolbar
elements per default ... thus we have to omit the labels and "hitting"
the buttons gets harder (due to their small size). Increasing the icon
size (better: automatic setting) will improve that, but we won't improve
the understandability of the metaphors :-)

Here is some more information ...

Platform Differences (scroll a bit down, please)
http://wiki.services.openoffice.org/wiki/Platform_UI_Differences#Differences

How Toolbars and Labels are Used within Gnome
http://library.gnome.org/devel/hig-book/stable/toolbars-labels-tooltips.html.en

> (ws robert 22435)$ xdpyinfo | egrep "(dimensions|dots per inch)" 
>   dimensions:    1920x1080 pixels (518x291 millimeters)
>   resolution:    94x94 dots per inch
>
> It is strange for me tho that linux *hardcodes* 75. Where is taht
> hardcoded?

I don't know whether this helps in general, but in Gnome there is a DPI
setting that is used to scale the font display. At least for my screen
is 96x96 DPI (using the command above).

Cheers,
Christoph


> On (2011-01-05 17:14), Michael Meeks wrote:
> > Hi Robert,
> >
> > On Wed, 2011-01-05 at 16:24 +0100, Robert Nagy wrote:
> > > On (2011-01-05 14:27), Michael Meeks wrote:
> > > >         So - I would prefer to stick with large icons; and not use the DPI
> > > > setting. I suggest instead, that we only use large icons if the true Y
> > > > resolution > 768 - how does that sound ?
> > >
> > > Oh wait, I misunderstood. That is wrong. I am on a 1920x1080 display
> >
> >     :-) so - as I say; the DPI is a constant of 75 across the Linux
> > desktop, so this is not a switch but a hard coded setting :-)
> >
> >     I am still convinced that large icons, on a reasonably sized screen
> > give a -far- more useful view of the metaphore for a beginner user. As I
> > say, advanced users can make it smaller.
> >
> > > and i still prefer the small icons, it is like that in _every_ app. So
> > > we should stick to the DPI.
> >
> >     Well; looking at gedit - it is using gtktoolbar.c's:
> >
> > #define DEFAULT_ICON_SIZE GTK_ICON_SIZE_LARGE_TOOLBAR
> >
> >     ie. the same size (large) icons that we are using here. Perhaps the
> > size setting is coming from the theme, in which case we should extract
> > it and use exactly that setting in LibreOffice - can you have a dig ?
> > (can you check that stock gtk+ apps do indeed have small toolbar
> > icons ?).
> >
> >     Thanks,
> >
> >             Michael.
> >
> > -- 
> >  michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice