Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces

Drat, I meant to send:

I removed the aScanner.GetLen() > 1 check because if you leave that
in, it doesn't count words consisting of a single character as words.
So it wasn't counting words like "a" or "i"

On 27 October 2010 23:38, Cedric Bosdonnat <cedric.bosdonnat.ooo@free.fr> wrote:
> Hi Mattias,
>
> On Wed, 2010-10-27 at 18:26 +1100, Mattias Johnsson wrote:
> > Here are my patches for the easy hack / programming task "Count
> > characters without whitespace in the Writer statistics." Since it's
> > something translators have apparently been asking for OO.org to have
> > for eight years (see
> > http://www.openoffice.org/issues/show_bug.cgi?id=10356 and
> > https://bugs.freedesktop.org/show_bug.cgi?id=30550) it'd be nice for
> > it to appear in LibreOffice :-)
>
> Thanks for your patches, I reviewed them and cleaned up a bit the
> SwTxtNode::WordCount() method as you added some commented code. I also
> kept the condition for the aScanner.GetLen() > 1... is there any reason
> to remove that?
>
> I removed the task from the EasyTasks list. Keep providing nice patches
> like those ;)
>
> Regards,
>
> --
> Cédric Bosdonnat
> LibreOffice hacker
> http://documentfoundation.org
> OOo Eclipse Integration developer
> http://cedric.bosdonnat.free.fr
>
>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice