Re: [Libreoffice] [PUSHED] regression tests - for word count ...

Hi LeMoyne,

On Mon, 2010-11-01 at 23:35 -0700, LeMoyne wrote:
> [PATCH] Fixes char overcount when selection ends in middle of word  
> Patch in sw changes only one object: sw/source/core/txtedt.cxx 
>
> Error was reported by Sophie Gautier on bug 30550
> https://bugs.freedesktop.org/show_bug.cgi?id=30550

The patch looks good to me, I pushed it! Many thanks for it.

> Still doesn't count hidden paras, hidden or red-lined text.  Also pretty
> sure it doesn't count headers and footers and may count notes: it has been a
> while since I looked at those (at the Doc level).  Treats any block of
> non-space characters as a word.  Counts outline numbers and bullets.  Was
> tempted to rip out the bullet count (1 word, 1 char and 1 non-blank char)
> but left it as pre-existing comic relief behavior.  

Ok, may be improving these cases would be needed before closing the
issue...

> I suggest a 2 column tabular layout of the Word Count dialog as in gedit. 

+1

> The paragraph count is held on the same DocStat record as the word and char
> counts and is already available to the dialog.  I will redo the dialog
> layout if that is not already done a few days from now.  

Great, I'm waiting for your patch ;)

Regards,

--
Cedric