Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces

Cedric Bosdonnat <cedric.bosdonnat.ooo -AT- free.fr>
Wed, 27 Oct 2010 14:38:38 +0200

Hi Mattias,

On Wed, 2010-10-27 at 18:26 +1100, Mattias Johnsson wrote:

Here are my patches for the easy hack / programming task "Count
characters without whitespace in the Writer statistics." Since it's
something translators have apparently been asking for OO.org to have
for eight years (see
http://www.openoffice.org/issues/show_bug.cgi?id=10356 and
https://bugs.freedesktop.org/show_bug.cgi?id=30550) it'd be nice for
it to appear in LibreOffice :-)


Thanks for your patches, I reviewed them and cleaned up a bit the
SwTxtNode::WordCount() method as you added some commented code. I also
kept the condition for the aScanner.GetLen() > 1... is there any reason
to remove that?

I removed the task from the EasyTasks list. Keep providing nice patches
like those ;)

Regards,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

Context

[Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces · Mattias Johnsson
- Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces · Cedric Bosdonnat
  - Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces · Mattias Johnsson
  - Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces · Mattias Johnsson
- Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces · LeMoyne
  - Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces · LeMoyne
    - Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces · Mattias Johnsson
      - Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces · LeMoyne
      - Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces · Norbert Thiebaud
    - [Libreoffice] regression tests - for word count ... · Michael Meeks
      - Re: [Libreoffice] regression tests - for word count ... · Wols Lists
        
        Re: [Libreoffice] regression tests - for word count ... · Michael Meeks

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.