Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

On Wed, Oct 20, 2010 at 4:24 AM, Kohei Yoshida <kyoshida@novell.com> wrote:
> On Mon, 2010-10-18 at 14:06 -0400, Kohei Yoshida wrote:
> > On Mon, 2010-10-18 at 16:53 +0100, Michael Meeks wrote:
> > >         Everything except the 'filters' patch has been either pushed,
> > > or sent
> > > to the component maintainer for review.
> >
> > And I'm reviewing the calc part of your patch.  At first glance there
> > are several hunks that I'd like to keep, but I'll go through it soon.
> > I'll be traveling in the next few days, so my time will be rather
> > limited while traveling...
>
> Just finished reviewing and applied most of your changes.  Thanks a lot!

Was it intentional to add dead code in the remove dead code patch :-) ?

----------------------- sc/source/ui/docshell/docsh4.cxx -----------------------
index 49d763c..353fff9 100644
@@ -2128,6 +2128,7 @@ void ScDocShell::Print( SfxProgress& rProgress,
PrintDialog* pPrintDialog,
                 }
             }

+#if 0
             if ( n+1 < nCollateCopies &&
                  (pPrinter->GetDuplexMode() == DUPLEX_SHORTEDGE ||
pPrinter->GetDuplexMode() == DUPLEX_LONGEDGE) &&
                  ( nPrinted % 2 ) == 1 )
@@ -2138,11 +2139,10 @@ void ScDocShell::Print( SfxProgress&
rProgress, PrintDialog* pPrintDialog,
                 // (same as in Writer ViewShell::Prt)

                 // FIXME: needs to be adapted to XRenderable interface
-                #if 0
                 pPrinter->StartPage();
                 pPrinter->EndPage();
-                #endif
             }
+#endif
         }
     }

Norbert

> Kohei
>
> --
> Kohei Yoshida, LibreOffice hacker, Calc
> <kyoshida@novell.com>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice