Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

Hi there,

On Mon, 2010-10-18 at 16:06 +0300, Povilas Kanapickas wrote:
> I've done some work on entry level tasks. Specifically, I've removed
> all #if 0 blocks in the LibreOffice source tree.

        So - I did some more review; I left a few useful / commented pieces in
that were removed, but so far it looks positive.

        The 650k line diff to the binfilter is difficult to review in linear
time ;-) If we could extract the scripted element from that - it would
be helpful. I was also interested in things like the UI string changes
in binfilters - what was all that about ? :-)

        Why we still have UI strings in the binfilter is another question - is
there a useful task to prune down things like:

        binfilter/bf_sw/source/ui/inc/swmn.hrc

        I can't believe we really need that stuff. Anyhow - luckily the
binfilter is known to be a disasterous mess of obsolete code - so, if we
had a script we could apply it easily.

> I contribute under LGPLv3+. Hope you can merge my contributions :)

        Everything except the 'filters' patch has been either pushed, or sent
to the component maintainer for review.

        Thanks !

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot