[Libreoffice] [Fwd: Re: [PATCH] cppcheck warning in sw/source/ui/uiview/viewprt.cxx]

I thinking of cutting my fingers off, I seem to be completely unable to
reliably press 'Reply-to-all'

--- Begin Message ---

• "Noel Power" <nopower -AT- novell.com>
• Tue, 05 Oct 2010 04:59:04 -0600

Hi Caolan
On Tue, 2010-10-05 at 10:31 +0100, Caolán McNamara wrote:

On Tue, 2010-10-05 at 03:24 -0600, Noel Power wrote:

Anybody have any idea or thoughts about that ?

Take the OSL_* family as the canonical ones, and typically replace the
others when them.

You mean to remove all those DBG_XXXX ones and all the fancy logging,
filtering support etc. or just the ASSERT(s) Does anyone use that
dbgutil stuff? ( /me recall that maybe there is some extra usage ( or is
it just annoyance ) using that with windows )

 Remove vos in total.

sure but that part of a different task, although replacing any instance
of VOS_ASSERT would be a start ( confusion reduction ) 

We're rather riddled with FOO_ASSERTs which are generally blithely
ignored and unseen as its rare enough to build with --enable-debug
and/--enable-dbgutil.

Not so rare to build with debug though right? ( same as --enable-debug )
 But can't argue that mostly the dbgutil stuff is invisible ( at least
to me since I never build it )

 Another task is that we should be basically silent
without asserting all over the shop when building with ASSERTs enabled
if there's nothing actually wrong happening.

I will put something in the wiki, please feel free to update it with
your better wisdom :-)

Noel

--- End Message ---