Re: [libreoffice-l10n] Wrong translations of formula function names and identifiers [1/3]

Hi Eike,

On Wed, Oct 16, 2019 at 8:36 PM Eike Rathke <erack@redhat.com> wrote:
> I did a short investigation how some function name was translated and
> stumbled upon quite some mess in general in the formula module.
> Specifically, names in msgctxt "RID_STRLIST_FUNCTION_NAMES":

Thanks for that!

> * Translated function names MUST NOT contain spaces, parentheses,
>   hyphens, or anything else that would be an operator in spreadsheet
>   formula context. Function names may only contain letters (of any
>   alphabet or script of course, not just ASCII) or digits or '.' dot or
>   '_' underscore, and must start with a letter.
> […]
>     grep -E -A1 'msgid "[A-Z0-9._]+"' translations/source/*/formula/messages.po|grep -B1 'msgstr 
> ".*[-+*/ ()~]'
>
>     (all on one line) also repeated on top of the attached list.

Oh, if that ends up in actual translations repository (as opposed to
translations-weblate intermediate one on github), then the check for
function names in pocheck should be amended according.
Right now it checks for duplicates only it seems...
https://gerrit.libreoffice.org/plugins/gitiles/core/+/master/l10ntools/source/pocheck.cxx#136

(and likely should also be put into a custom check to weblate)

> * Translated identifiers like "#All" or "#Headers" if they start with
>   a '#' hash character MUST start with a '#' character also in the
>   translation, this is vital to recognize them as table reference
>   identifiers (or error constants possibly).

Thx - I think you already added the "L10n: preserve the leading '#'
hash character in translations." comment to all relevant strings?

>     grep -E -A1 'msgid "#' translations/source/*/formula/messages.po | grep -B1 'msgstr "[^#"]'
>
> While these wrong translations display correctly when loading
> a document, any attempt to compile such formula expression that does not
> meet the criteria will fail.
>
> PLEASE, check the attached lists for your language's translation (the
> list is sorted by language codes between translations/source/ and
> /formula/messages.po) and correct errors ASAP; corrections should also
> end up in the 6-3 branch, Cloph probably can help with that.

As they break functionality, I can at least make sure that no invalid
translations are in the repo, pocheck removes problematic translations

> Also, (possibly after any change) please load the 6.2 attachment
> https://bugs.documentfoundation.org/attachment.cgi?id=150855 of
> https://bugs.documentfoundation.org/show_bug.cgi?id=93992 in your
> translated UI, to check for duplicated function names.

ciao
Christian

-- 
To unsubscribe e-mail to: l10n+unsubscribe@global.libreoffice.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.libreoffice.org/global/l10n/
Privacy Policy: https://www.documentfoundation.org/privacy