On 21 Nov 2019, at 10:47 pm, Luboš Luňák <l.lunak@collabora.com> wrote:
On Thursday 21 of November 2019, Stephan Bergmann wrote:
On 21/11/2019 11:25, Chris Sherlock wrote:
Just a quick query to the ML - when I’m attempting to troubleshoot
issues with EMF files, I use SAL_INFO to see what records it is reading.
It’s already helped me work out some issues, in particular the last one
was around custom line caps.
How else should we be doing this?
I guess there's no ideal answer.
While I agree that there's no ideal answer, the way I see it is that there
should be a preferred answer, and that's how I see SAL_INFO.
Hm, sounds rather like a misuse of the SAL log facility to me. (Each
use of it comes at a cost, so it shouldn't be used too lightly for
anything but logging unusual events.)
E.g. currently while writing the Skia VCL backend I've added SAL_INFO to
pretty much to each of the drawing functions. And of course normally nobody
wants to see that, but it can be useful if needed, all it takes is setting
SAL_LOG, and it fits nicely with the code (no #ifdefs or anything). So I
disagree with it being just for the unusual stuff (that's SAL_WARN).
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.