Re: git-hook: Catch tab indentation also for makefiles

Bjoern Michaelsen <bjoern.michaelsen -AT- libreoffice.org>
Tue, 5 Sep 2017 22:43:54 +0200

Hi,

On Mon, Sep 04, 2017 at 02:30:06PM +0100, Tamas Zolnai wrote:

I just noticed that for makefiles (*.mk) git does not check whether the
commit contains tab indentation. As I know we use spaces also for makefiles
for indentation, right? So I added a patch changing pre-commit hook to check
tab also for makfiles: https://gerrit.libreoffice.org/#/c/41897/ I hope it's
ok. I don't know who used to care of git stuff.


Late to this show, but yeah:

GNU make still requires tabs for its rules/recipe syntax etc.

That we get away with spaces is only because gbuild widely is macro calls with
whitespace separated lists as arguments. And for those, tabs-vs-space doesnt
matter.

Best,

Bjoern

Context

git-hook: Catch tab indentation also for makefiles · Tamas Zolnai
- Re: git-hook: Catch tab indentation also for makefiles · Stephan Bergmann
  - Re: git-hook: Catch tab indentation also for makefiles · Zolnai Tamás
    - Re: git-hook: Catch tab indentation also for makefiles · jani libreoffice
      - Re: git-hook: Catch tab indentation also for makefiles · Zolnai Tamás
- Re: git-hook: Catch tab indentation also for makefiles · Bjoern Michaelsen

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.