Re: git-hook: Catch tab indentation also for makefiles

Stephan Bergmann <sbergman -AT- redhat.com>
Mon, 4 Sep 2017 15:43:20 +0200

On 09/04/2017 03:30 PM, Tamas Zolnai wrote:

I just noticed that for makefiles (*.mk) git does not check whether the commit contains tab 
indentation. As I know we use spaces also for makefiles for indentation, right? So I added a patch 
changing pre-commit hook to check tab also for makfiles:
https://gerrit.libreoffice.org/#/c/41897/
I hope it's ok. I don't know who used to care of git stuff.

I think temporary GNU make still needs recipe lines to start with tabcharacters? And in any case, our makefiles are apparently written withlots of tab characters all over the place. I'd suggest to revert (atleast for now).

Context

git-hook: Catch tab indentation also for makefiles · Tamas Zolnai
- Re: git-hook: Catch tab indentation also for makefiles · Stephan Bergmann
  - Re: git-hook: Catch tab indentation also for makefiles · Zolnai Tamás
    - Re: git-hook: Catch tab indentation also for makefiles · jani libreoffice
      - Re: git-hook: Catch tab indentation also for makefiles · Zolnai Tamás
- Re: git-hook: Catch tab indentation also for makefiles · Bjoern Michaelsen

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.