Re: git-hook: Catch tab indentation also for makefiles

2017-09-04 15:43 GMT+02:00 Stephan Bergmann <sbergman@redhat.com>:

> On 09/04/2017 03:30 PM, Tamas Zolnai wrote:
>
> > I just noticed that for makefiles (*.mk) git does not check whether the
> > commit contains tab indentation. As I know we use spaces also for makefiles
> > for indentation, right? So I added a patch changing pre-commit hook to
> > check tab also for makfiles:
> > https://gerrit.libreoffice.org/#/c/41897/
> > I hope it's ok. I don't know who used to care of git stuff.
>
> I think temporary GNU make still needs recipe lines to start with tab
> characters?  And in any case, our makefiles are apparently written with
> lots of tab characters all over the place.  I'd suggest to revert (at least
> for now).


Yeah, I see that tabs and spaces are mixed in makefiles. That's why I
thought it would be good to make it consistent similar to other source
files.
I did not push it yet. It's on gerrit. So I can abandon it.