Re: git-hook: Catch tab indentation also for makefiles

Zolnai Tamás <zolnaitamas2000 -AT- gmail.com>
Mon, 4 Sep 2017 19:44:53 +0200

2017-09-04 17:13 GMT+02:00 jani libreoffice <jani@libreoffice.org>:


I think temporary GNU make still needs recipe lines to start with tab

characters?  And in any case, our makefiles are apparently written with
lots of tab characters all over the place.  I'd suggest to revert (at least
for now).



Yeah, I see that tabs and spaces are mixed in makefiles. That's why I
thought it would be good to make it consistent similar to other source
files.
I did not push it yet. It's on gerrit. So I can abandon it.


build breaks on my mac when I replace tab with spaces, so please do not
make this a demand.


OK, I abandoned the patch. Thanks!

Context

git-hook: Catch tab indentation also for makefiles · Tamas Zolnai
- Re: git-hook: Catch tab indentation also for makefiles · Stephan Bergmann
  - Re: git-hook: Catch tab indentation also for makefiles · Zolnai Tamás
    - Re: git-hook: Catch tab indentation also for makefiles · jani libreoffice
      - Re: git-hook: Catch tab indentation also for makefiles · Zolnai Tamás
- Re: git-hook: Catch tab indentation also for makefiles · Bjoern Michaelsen

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.