Hi Kohei,
Kohei Yoshida píše v St 10. 12. 2014 v 21:09 -0500:
My belief was that this was not a controvercial change, but it appears
that it is. If there is a strong objection I'll stop doing it. If not,
I'd like to continue pursing this since it seems to improve both of the
2 aforementioned points, and I've only covered perhaps 10-20% of all
possible candidates.
I don't have objection if _you_ are doing that :-) It's fine for me
when it is targeted, focused on the goals you've outlined.
But I did not know the reasons for pimpl-ization previously, and my fear
was that this might become a favorite Easy Hack where we'd have loads of
people pimpl-izing just everything; which was my concern from 2 reasons:
* debuggability / code reading perspective: one more level of
indirection that you need to go through to see what's going on
* cost of new/delete of the Impl class + cost of the pImpl-> calls
If it is not going to become such an Easy Hack, I am OK with that of
course.
All the best,
Kendy
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.