Re: 'master' 'make check' lcov code coverage report

On Fri, Nov 7, 2014 at 1:28 PM, Maarten Hoes <hoes.maarten@gmail.com> wrote:
> > all these 3 point could be solved by putting that job under jenkins
> > control.. I'll have a look at doing that.
> Alright, so no complex error handling code then. But I guess you still will
> want the script to exit with a non-zero exit code if a single one of the
> commands in it fails (so jenkins can pick up on the failure) instead of it
> just blindly continuing as if nothing happened ?

yes.

> > Ideally I would chain that job behind a sucessful build, so that this
> > does not happen
> > iow first fidn a 'good' commit, then submit the job....
> > but before that happen, the msot usefull way would be I think to just
> > drop that build, and retry a bit latter with hopefully a good build at
> > that time
> So in other words: instead of 'make -k check' do a 'make check', and have
> the script exit with a non zero exit code if the make command fails ?

yes

> > > 6.)
> > > Should I send a license/code statement to the list for the 'code', even
> > > though this is just a shell script ?
> >
> > This is not really part of the product we package... os just put an
> > appropriate open-source license statement at the to of the script.
> > and prolly the best is to find a place for it in 'buildbot.git'
> > (accessble via gerrit)
> So where does this 'buildbot.git' live, and how do I set up submit access to
> that so I can commit the script ?

as I said :-) gerrit.
gerrit.libreoffice.org/buildbot

same process to upload patches than core.git  :-)

see content at
https://gerrit.libreoffice.org/gitweb?p=buildbot.git;a=tree
you can prolly just create a lcov directory and put stuff in there...

Norbert