Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning

Eike Rathke <erack -AT- redhat.com>
Tue, 17 Sep 2013 01:14:07 +0200

Hi Winfried,

On Monday, 2013-09-16 19:08:29 +0200, Eike Rathke wrote:

I still did not see that assertion,


Ok, I did..

but I see a bunch of other assertions,


and reimplemented OpCodeMap::copyFrom() to take care of these things.

You'd need to rebase or cherry-pick these commits:

2f2ee162ac521b9ad90651429253b9bf569f1797
2e60a634ec8ce939ec9dc3df10f12cee84bd7c7e
4fc4a3f2e5f82ed473fc6e9c22aa3fdf9178c6ff
24726fe2de005fe9532487907f8867259f61260c
3ec486639befae454eebfd5b8f5dbc88aa357404

I wonder if the AddIn symbols shouldn't be replaced in
OpCodeMap::copyFrom() as well.. there's even a TODO comment suggesting
so ;-)

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
For key transition see http://erack.de/key-transition-2013-01-10.txt.asc
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack

Attachment: pgpTKzy43H7oa.pgp
Description: PGP signature

Context

Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning · Eike Rathke
- Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning · Winfried Donkers
  - Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning · Eike Rathke
    - RE: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning · Winfried Donkers
      - Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning · Eike Rathke
        
        Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.