Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi Winfried,

On Monday, 2013-09-16 14:03:20 +0200, Winfried Donkers wrote:

-    DBG_ASSERT( 0 < eOp && sal_uInt16(eOp) < mnSymbols, "OpCodeMap::putOpCode: OpCode out of 
range");
-    if (0 < eOp && sal_uInt16(eOp) < mnSymbols)
+    DBG_ASSERT( sal_uInt16(eOp) < mnSymbols, "OpCodeMap::putOpCode: OpCode out of range");
+    if (sal_uInt16(eOp) < mnSymbols)

I never saw that and I'm usually on a dbgutil build.
May it be that it was caused by another change you did?

It occurs with the changes as in https://gerrit.libreoffice.org/#/c/5691/ (your review on that 
one is highly appreciated), there may be a connection.

Reviewed..

I still did not see that assertion, but I see a bunch of other assertions,
formula/source/core/api/FormulaCompiler.cxx:501: OpCodeMap::putOpCode: reusing OpCode ...
It is not related to your change. It occurs always when an UI language
!= en-US is active and the "Use English function names" option is
activated. For en-US there are still four reuses with that option on,

OpCode 256 (ZGZ)
OpCode 362 (TABLE)
OpCode 411 ()
OpCode 412 ()

The last two would be the new functions FILTERXML and WEBSERVICE

I'll revert the other commit that excluded opcode 0 from the assertion
and investigate what's going wrong else.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
For key transition see http://erack.de/key-transition-2013-01-10.txt.asc
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack

Attachment: pgpdCK4uje_IO.pgp
Description: PGP signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.