RE: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning

Winfried Donkers <W.Donkers -AT- dci-electronics.nl>
Mon, 16 Sep 2013 14:03:20 +0200

Hi Eike,

Just got back from holidays, sorry I have kept you waiting.

-    DBG_ASSERT( 0 < eOp && sal_uInt16(eOp) < mnSymbols, "OpCodeMap::putOpCode: OpCode out of 
range");
-    if (0 < eOp && sal_uInt16(eOp) < mnSymbols)
+    DBG_ASSERT( sal_uInt16(eOp) < mnSymbols, "OpCodeMap::putOpCode: OpCode out of range");
+    if (sal_uInt16(eOp) < mnSymbols)

I never saw that and I'm usually on a dbgutil build.
May it be that it was caused by another change you did?


It occurs with the changes as in https://gerrit.libreoffice.org/#/c/5691/ (your review on that one 
is highly appreciated), there may be a connection.

Winfried

Context

Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning · Eike Rathke
- Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning · Winfried Donkers
  - Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning · Eike Rathke
    - RE: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning · Winfried Donkers
      - Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning · Eike Rathke
        
        Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.