Re: [Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning

Hi Winfried,

Sorry, I didn't notice your reply until now.

On Tuesday, 2013-08-27 19:01:00 +0200, Winfried Donkers wrote:

> > > -    DBG_ASSERT( 0 < eOp && sal_uInt16(eOp) < mnSymbols, "OpCodeMap::putOpCode: OpCode out of 
> > > range");
> > > -    if (0 < eOp && sal_uInt16(eOp) < mnSymbols)
> > > +    DBG_ASSERT( sal_uInt16(eOp) < mnSymbols, "OpCodeMap::putOpCode: OpCode out of range");
> > > +    if (sal_uInt16(eOp) < mnSymbols)
> > When did you encounter that warning?
> That warning occurred e.g. on start up of calc.

I never saw that and I'm usually on a dbgutil build.

May it be that it was caused by another change you did?

> FormulaCompiler::OpCodeMap::putOpCode() is called for opCode 0 and
> then for opCode 6 till 412 (as the warning ' reusing opCode'  occurs
> as many times).

That's odd.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
For key transition see http://erack.de/key-transition-2013-01-10.txt.asc
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack

Attachment: pgpLFm7ZQMqtj.pgp
Description: PGP signature