Re: oox service mess

On 05/31/2013 10:08 AM, Noel Power wrote:
> On 30/05/13 17:44, Stephan Bergmann wrote:
> > The problem is that sc/util/scfilt.component claims that the scfilt
> > library contains an implementation of the
> > com.sun.star.sheet.FilterFormulaParser service with implementation
> > name "com.sun.star.comp.oox.xls.FormulaParser", but
> > scfilt_component_getFactory does not actually support it.
[...]
> hmm I confess I an not quite sure how/when/why the implementatation was
> removed, I remember moving the implementation ( like you mentioned )
> perhaps I missed something in the move that made it seem like the
> service could no longer be instantiated ( and then someone else removed
> it ) I don't know, it's even possible I removed it myself ( do you know
> from whatever archaeology you already did ? )

The C++ class implementing "com.sun.star.comp.oox.xls.FormulaParser" was 
OOXMLFormulaParser, and the head of "git log -SOOXMLFormulaParser" reads

> commit effda59a12cedd3cf200d2e9f5186a623b0855bb
> Author: Caolán McNamara <caolanm@redhat.com>
> Date:   Tue Mar 27 23:26:27 2012 +0100
>
>     callcatcher: regenerate list
>
> commit 887d7945addeb823e0d3f783609c4e79d92ad4a7
> Author: Caolán McNamara <caolanm@redhat.com>
> Date:   Tue Mar 27 21:40:57 2012 +0100
>
>     callcatcher: update list
>
> commit 226d310c1a31238b7f07d8e7e42ec75f0280fba5
> Author: Petr Vorel <petr.vorel@gmail.com>
> Date:   Thu Mar 22 20:14:13 2012 +0100
>
>     remove unused code (oox)
>
> commit a92129ec175a1362e61a474cf64992f283db74b4
> Author: Caolán McNamara <caolanm@redhat.com>
> Date:   Tue Mar 20 01:07:37 2012 +0000
>
>     callcatcher: update list, I suspect SvLBoxBmp cannot be instantiated
>
> commit 8ada1cd2846e5e60ad63250c68ddea3a9356546f
> Author: Noel Power <noel.power@novell.com>
> Date:   Fri Mar 16 12:28:31 2012 +0000
>
>     move excel related oox bits to sc

(And the implementations of "com.sun.star.comp.oox.xls.BiffDetector", 
"com.sun.star.comp.oox.xls.ExcelBiffFilter", and 
"com.sun.star.comp.oox.xls.ExcelVbaProjectFilter" I mentioned in the 
original mail also appeared to get removed with "automatic" 
callcatcher-related clean-up, so that's what worried me a little.)

Stephan