Re: [PATCH] coverity#983561: Arguments in wrong order

Thomas Arnhold <thomas-libo -AT- arnhold.org>
Sun, 31 Mar 2013 15:21:10 +0200

Hi Regina,

you're right, the other methods are using the order (fVer, fHor), likecreateUnitSpherePolyPolygon() does. So the definition is correct:


inline B3DPoint getPointFromCartesian(double fVer, double fHor)

But on the call side it's used like:

aNew.append(getPointFromCartesian(fHor, fVer));

So here got something mixed up.

Thomas

Context

[PATCH] coverity#983561: Arguments in wrong order · Julien Nabet (via Code Review)
- Re: [PATCH] coverity#983561: Arguments in wrong order · Regina Henschel
  - Re: [PATCH] coverity#983561: Arguments in wrong order · julien2412
    - Re: [PATCH] coverity#983561: Arguments in wrong order · Regina Henschel
      - Re: [PATCH] coverity#983561: Arguments in wrong order · Thomas Arnhold
        
        Re: [PATCH] coverity#983561: Arguments in wrong order · Regina Henschel
        
        Re: [PATCH] coverity#983561: Arguments in wrong order · Regina Henschel
        
        Re: [PATCH] coverity#983561: Arguments in wrong order · Thomas Arnhold
- [ABANDONED] coverity#983561: Arguments in wrong order · Julien Nabet (via Code Review)

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.