Re: [PATCH] coverity#983561: Arguments in wrong order

julien2412 <serval2412 -AT- yahoo.fr>
Sun, 31 Mar 2013 03:10:07 -0700 (PDT)

Hi Regina,

I knew I was right to submit this patch for review and not push it directly
:-)
In fact, I just picked up a coverity report and took a look to Opengrok (see
http://opengrok.libreoffice.org/search?q=getPointFromCartesian&project=core&defs=&refs=&path=&hist=).
Ovbiously, I know nothing about 3D coordinate system, now could argument
names be changed a little so it wouldn't confuse Coverity scan (and also me
:-) ) ? (perhaps include your explanation in source code or a link to
Wikipedia or something). I had searched on Wikipedia but didn't find/didn't
know how to search about this.

Thank you for your useful feedback Regina!

Kind regards too

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/PATCH-coverity-983561-Arguments-in-wrong-order-tp4047117p4047164.html
Sent from the Dev mailing list archive at Nabble.com.

Context

[PATCH] coverity#983561: Arguments in wrong order · Julien Nabet (via Code Review)
- Re: [PATCH] coverity#983561: Arguments in wrong order · Regina Henschel
  - Re: [PATCH] coverity#983561: Arguments in wrong order · julien2412
    - Re: [PATCH] coverity#983561: Arguments in wrong order · Regina Henschel
      - Re: [PATCH] coverity#983561: Arguments in wrong order · Thomas Arnhold
        
        Re: [PATCH] coverity#983561: Arguments in wrong order · Regina Henschel
        
        Re: [PATCH] coverity#983561: Arguments in wrong order · Regina Henschel
        
        Re: [PATCH] coverity#983561: Arguments in wrong order · Thomas Arnhold
- [ABANDONED] coverity#983561: Arguments in wrong order · Julien Nabet (via Code Review)

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.