Re: [PUSHED 3.6] was vcl checkbox behaviourRe: vcl checkbox behaviour

Petr Mladek <pmladek -AT- suse.cz>
Wed, 08 Aug 2012 10:16:26 +0200

Noel Power píše v Pá 06. 07. 2012 v 14:41 +0100:

On 28/06/12 19:02, Jan Holesovsky wrote:
I ask 
for a review here.

the changes in question are :
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a1345cd93a57ec7d9352f2c71ec2664332ce5e76
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2bc2d09bba2e3f34e8ce13571de9ff7007e1c2b6


The change makes sense. The patches look reasonable. It works. I checked
few things in the UI and did not find any side effects. It seems that
you did lots checks to do not break things => pushed into 3-6 branch:

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=99cad9fd7f413adecffc527d334eff616799cc4b
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=aea425a8cd851e6bee02247673c8996b58789484


Best Regards,
Petr

Context

vcl checkbox behaviour · Noel Power
- Re: vcl checkbox behaviour · Noel Power
- Re: vcl checkbox behaviour · Jan Holesovsky
  - Re: vcl checkbox behaviour · Noel Power
    - Re: vcl checkbox behaviour · Jan Holesovsky
      - Re: vcl checkbox behaviour · Noel Power
        
        Re: vcl checkbox behaviour · Noel Power
      - Re: REVIEW[3.6] was vcl checkbox behaviourRe: vcl checkbox behaviour · Noel Power
        
        Re: [PUSHED 3.6] was vcl checkbox behaviourRe: vcl checkbox behaviour · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.