Re: [REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB

Hello Noel

2012/8/2 Noel Power <nopower@suse.com>:
> On 02/08/12 17:15, Eike Rathke wrote:
> > Hi Noel,
> >
> > On Thursday, 2012-08-02 14:32:16 +0100, Noel Power wrote:
> >
> > > master:6068f2f7cf5d66c68241b3831851b413b2e0b3ba ( sorry don't have
> > > the cgit url as cgit is dead )
> >
> > git show 6068f2f7cf5d66c68241b3831851b413b2e0b3ba | vim -
> > works fine ;-)
> >
> > However, that is supposed to fix that comments disappear when saving to
> > .xls, correct (as bz is down as well ...) ? It doesn't for me in 3-6,
>
> but works in master right, <sigh> yes I did test it in 3.6 but I mustn't
> have reloaded there
>
> > reloading the .xls the comment is gone. The patch itself looks correct,
> > but apparently there's more to it.
> yes, markus sent me a mail pointing to
> http://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/excdoc.cxx#428
> which should have done the trick ( but it's obvious the mxNoteList isn't
> used ) it seems there is some confusion because of the co-existence of the
> old and new code, I will fix it ( but right now gotta take kid to surf
> life/rescue training ) with any luck the fresh air and a walk on the beach
> will clear my head and make it easier, anyway thanks for noticiing

I think you made the same mistake I did when I wrote the patch.
Opening a test file and resavinf it without changes will produce the
right output. As soon as you create a new file or change anything it
will not use the cached import values for the output.

I can take care of this bug if it helps. I think I know what is broken
in this case.

Regards,
Markus