Re: [REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB

Eike Rathke <erack -AT- redhat.com>
Thu, 2 Aug 2012 18:15:31 +0200

Hi Noel,

On Thursday, 2012-08-02 14:32:16 +0100, Noel Power wrote:

master:6068f2f7cf5d66c68241b3831851b413b2e0b3ba ( sorry don't have
the cgit url as cgit is dead )


git show 6068f2f7cf5d66c68241b3831851b413b2e0b3ba | vim -
works fine ;-)

However, that is supposed to fix that comments disappear when saving to
.xls, correct (as bz is down as well ...) ? It doesn't for me in 3-6,
reloading the .xls the comment is gone. The patch itself looks correct,
but apparently there's more to it.

Placing a breakpoint there revealed that a XclExpNote record is never
added.. some seconds later: this if a note is on a cell without content
... notes are saved only for cells with content.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgpEhGCz0N3KM.pgp
Description: PGP signature

Context

[REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB · Noel Power
- Re: [REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB · Eike Rathke
  - Re: [REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB · Noel Power
    - Re: [REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB · Markus Mohrhard
      - Re: [REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB · Noel Power
        
        (message not available)
        
        Re: [REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB · Noel Power
        
        Re: [PUSHED-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.