Re: [PATCH] Remove unused argument from gridwin.cxx

Cor Nouws <oolst -AT- nouenoff.nl>
Wed, 13 Jun 2012 08:20:10 +0200

Hi,

Eike Rathke wrote (13-06-12 00:56)

That's the old AutoFilter button dialog, now obsoleted by Kohei's new
dialog implemented in LaunchAutoFilterMenu(). In fact
LaunchDataSelectMenu() now is only called with bDataSelect=true so the
entire !bDataSelect code branch and the parameter can be removed.

I see a big (and growing) difference in possibilities and use case forthe old en new version of the autofilter. If the code still is there, Icould try to add a Data > Filter > Autofilter simple as second item tothe menu.Would that be an idea to ask at UX, or will it introducecode-troubles/ugliness?


Cheers,


--
 - Cor
 - http://nl.libreoffice.org

Context

[PATCH] Remove unused argument from gridwin.cxx · Cor Nouws
- Re: [PATCH] Remove unused argument from gridwin.cxx · Markus Mohrhard
  - Re: [PATCH] Remove unused argument from gridwin.cxx · Cor Nouws
  - Re: [PATCH] Remove unused argument from gridwin.cxx · Eike Rathke
    - Re: [PATCH] Remove unused argument from gridwin.cxx · Cor Nouws
      - Re: [PATCH] Remove unused argument from gridwin.cxx · Eike Rathke
        
        Re: [PATCH] Remove unused argument from gridwin.cxx · Cor Nouws
        
        Re: [PATCH] Remove unused argument from gridwin.cxx · Eike Rathke
- [PUSHED] Remove unused argument from gridwin.cxx · Fridrich Strba

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.