Hi,
As written in the previous mail, apparently, SCSTR_ALLFILTER is not used.
Therefore I removed SCSTR_ALLFILTER from sc/source/ui/view/gridwin.cxx,
where it is passed to a pFilterBox object, but has no effect.
To me it looks that SCSTR_ALLFILTER isn't used anywhere.
opengrok shows it in the soource file:
http://opengrok.libreoffice.org/xref/core/sc/source/ui/src/scstring.src#589
and in the define file:
http://opengrok.libreoffice.org/xref/core/sc/inc/sc.hrc#885
Remove it?
Regards,
--
- Cor
- http://nl.libreoffice.org
From a2bcfbf565f9bae8b7335a68639e414690305340 Mon Sep 17 00:00:00 2001
From: Cor Nouws <oolst@nouenoff.nl>
Date: Sun, 10 Jun 2012 22:01:29 +0200
Subject: [PATCH 1/2] Remove unused argument
Change-Id: Id646516a71800fbc0fe82595b51f4468f12954d3
---
sc/source/ui/view/gridwin.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 40e8f38..12168f8 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -1228,7 +1228,7 @@ void ScGridWindow::LaunchDataSelectMenu( SCCOL nCol, SCROW nRow, bool
bDataSelec
long nMaxText = 0;
// default entries
- static const sal_uInt16 nDefIDs[] = { SCSTR_ALLFILTER, SCSTR_TOP10FILTER, SCSTR_STDFILTER,
SCSTR_FILTER_EMPTY, SCSTR_FILTER_NOTEMPTY };
+ static const sal_uInt16 nDefIDs[] = { SCSTR_TOP10FILTER, SCSTR_STDFILTER,
SCSTR_FILTER_EMPTY, SCSTR_FILTER_NOTEMPTY };
const size_t nDefCount = SAL_N_ELEMENTS(nDefIDs);
for (i=0; i<nDefCount; i++)
{
--
1.7.9.5
Context
- [PATCH] Remove unused argument from gridwin.cxx · Cor Nouws
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.