On Tuesday 12 of June 2012, Michael Stahl wrote:
i've fixed the other ones, please review and push to libreoffice-3-5:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=cd18b8e313b792f5fc4
2edb3314a95d202406899
Pushed.
On Tuesday 12 of June 2012, Michael Stahl wrote:
On 12.06.2012 14:12, Tor Lillqvist wrote:
No, growing a vector (which push_back can do) invalidates all references
into the vector.
Would building with --enable-dbgutil on Linux (thus defining
_GLIBCXX_DEBUG) had caught this problem?
no, because there's no iterator involved: back() returns a reference to
the value_type.
It technically could, by checking in every method that can invalidate
references that the passed argument is not such a reference (to one of the
elements).
--
Lubos Lunak
l.lunak@suse.cz
Context
- Re: [REVIEW-3-5] Fix for crash in fdo#50868 (continued)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.