Re: [REVIEW-3-5] MSVC qsort issue

Muthu Subramanian K <sumuthu -AT- suse.com>

Mon, 25 Jun 2012 10:58:57 +0530


Other functions where CharAttribList::ResortAttribs() is called seem to
not guarantee that. So your fix would only help where the entire array
is already sorted, not where only partial sorting is to be retained.
Would be good to know if ContentNode::ExpandAttribs() and
ContentNode::CollapsAttribs() and EditDoc::InsertAttribInSelection() and
EditDoc::RemoveAttribs() really work as expected in these cases. Could
you please check?

It should. Because on Linux the array is indeed partial sorted. (It is

supposed to be, otherwise the bug will occur on Linux too). (Ref: the

sort checks only the start/end not the nWhich)

[Not sure, if I understood you right, please do correct me if I

misunderstood you. Thanks!]

- Muthu Subramanian

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.