Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage.

Stephan Bergmann <sbergman -AT- redhat.com>
Tue, 12 Jun 2012 13:54:58 +0200

On 06/12/2012 01:32 PM, Michael Stahl wrote:

On 12.06.2012 13:14, Muthu Subramanian K wrote:

Can somebody review and cherry-pick this one please?
http://cgit.freedesktop.org/libreoffice/core/commit/?id=25dd603fe2044f35341fe0c6d0b632c9295a824e


hmm... that old code looks legit to me?

No, growing a vector (which push_back can do) invalidates all referencesinto the vector.


Stephan

Context

[REVIEW-3-5] Fix for crash in fdo#50868 · Fridrich Strba
- Re: [REVIEW-3-5] Fix for crash in fdo#50868 · Fridrich Strba
  - Re: [REVIEW-3-5] Fix for crash in fdo#50868 · Michael Meeks
    - Re: [PUSHED:3-5] Fix for crash in fdo#50868 · Petr Mladek
- [REVIEW-3-5] MSVC stl usage. · Muthu Subramanian K
  - Re: [REVIEW-3-5] MSVC stl usage. · Muthu Subramanian K
  - [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage. · Michael Stahl
    - Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage. · Fridrich Strba
    - Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage. · Stephan Bergmann
      - Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage. · Tor Lillqvist
        
        Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage. · Michael Stahl
      - [REVIEW-3-5] Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage. · Michael Stahl
        
        [PUSHED-3-5]Re: [REVIEW-3-5] Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage. · Lubos Lunak
  - [REVIEW-3-5] MSVC qsort issue · Muthu Subramanian K
    - Re: [REVIEW-3-5] MSVC qsort issue · Eike Rathke
      - Re: [REVIEW-3-5] MSVC qsort issue · Muthu Subramanian K
        
        Re: [REVIEW-3-5] MSVC qsort issue · Eike Rathke
        
        Re: [REVIEW-3-5] MSVC qsort issue · Muthu Subramanian K

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.