On 06/04/2012 08:38 AM, Kohei Yoshida wrote:
It looks good to me. Please push to your branch.
Kohei
Done.
This leaves the SetTableStyle() and small part of NewSheet() which can't
be changed until SetTableStyle() is converted. Also, there are the
XShape and DrawPage methods.
On 06/01/2012 02:56 AM, Daniel Bankston wrote:
I think most of the other methods will follow fine from there except
for GetCurrentXDrawPage() and GetCurrentXShapes() which are separate
from the merge method concern. These methods get into things like
xmloff's XMLShapeImportHelper. Do we want to go here?
And of course we have already discussed trying to reexamine
ScMyTables::SetTableStyle() at some point.
I was looking at the XShape and DrawPage methods again and it would
require some untangling, but I don't think they would be as confusing as
SetTableStyle().
In an IRC conversation, Markus and I discussed that I work on
ScXMLTableRowCellContext::EndElement() in xmlcelli.cxx next. I will
work on EndElement() now and come back later to XShape, DrawPage, and
Styles in ScMyTables unless you guys think I should do differently.
Respectfully,
Daniel Bankston
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.