Re: Disabling file opening and saving in print preview mode

On Thu, 2012-05-31 at 11:48 -0400, Kohei Yoshida wrote:
> Hi there,
>
> While looking into this bug
> https://bugs.freedesktop.org/show_bug.cgi?id=48348
>
> I noticed that we actually allow saving and loading of document in print
> preview mode.  But to me that feels very odd.  Allowing to print from
> the preview mode makes sense, but saving the document makes little
> sense, and loading another document while in print preview mode even
> less so.
>
> What do you think about disabling these operations while in print
> preview mode?  That would make the above bug a non-issue as an added
> bonus.  Disabling them would also make the implementation much saner
> since it's not easy to support and maintain these functionalities in
> preview mode, since, technically, the print preview is an entirely
> different "application" that happens to use the same document model.
> Limiting the functionality of the preview mode to just allow previewing
> and printing would ease the maintenance burden substantially.
>
> Views and opinions appreciated.
>
> Kohei

I think it entirely reasonable not to offer Save from preview mode.
(I am the reporter of bug 48348, and I only realized that preview mode
was involved when I came back to my saved file with a fresh build and
then *accidentally* came out of preview mode.  That just about proves
that I did not need to save from preview mode, doesn't it? <grin />)

There remains a question about what the program should do when the
user (or system?) closes the application while a changed document is
in preview mode.  I think the Save/Discard dialog at this point is
still highly desirable.  If it is easiest to go back to the editing
program and let the editing program handle it, I think that would be
fine.

I think that the option to close a single unchanged document from
preview mode sounds useful but not essential.

All this, of course, comes from my way of working with LO.  YMMV.

HTH,
Terry.