Re: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress

On Mon, 2012-05-28 at 17:55 +0300, Tor Lillqvist wrote:
> Rob pointed out to me that much of his additions is in fact based on
> existing code, svtools/inc/svtools/miscopt.hxx etc.

        In which case the original LGPL licensing header sounds correct.

>  Which uses a similar oddly phrased comments, weird _Impl class with
> "reference counting" that is not a Pimpl, and other potential signs of
> micro-optimization for dubious gain. So is it OK then, and I am just
> being too sensitive? Since when am I a C++ expert anyway? Or should we
> ask him to try to simplify both the existing code and his own?

        A hard one; I'd not hold a volunteer's feature up for a cleanup, but
clearly having the code made beautiful is in the end a good goal OTOH -
this is some UNO using code so - our ability to make it succinct and
sweet is somewhat constrained anyway - cf. the property verbosity. A
second round of cosmetic fixes can be left to another commit presumably.
As for the isDisposing() that makes me nervous too. An object when
disposing should continue to function in some semi-sensible / no-op way
I suppose.

        HTH,

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot