Re: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress

Tor Lillqvist <tml -AT- iki.fi>
Mon, 28 May 2012 17:55:18 +0300

Rob pointed out to me that much of his additions is in fact based on
existing code, svtools/inc/svtools/miscopt.hxx etc. Which uses a
similar oddly phrased comments, weird _Impl class with "reference
counting" that is not a Pimpl, and other potential signs of
micro-optimization for dubious gain. So is it OK then, and I am just
being too sensitive? Since when am I a C++ expert anyway? Or should we
ask him to try to simplify both the existing code and his own?

--tml

Context

[PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress · Rob Snelders
- Re: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress · Tor Lillqvist
  - Re: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress · Rob Snelders
    - Re: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress · Tor Lillqvist
      - Re: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress · Rob Snelders
      - Re: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress · Tor Lillqvist
        
        Re: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress · Rob Snelders
        
        Re: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress · Michael Meeks
        
        Re: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress · Tor Lillqvist
        
        Re: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress · Rob Snelders

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.