Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi
somewhat of a containing fix ( I think there is other rework needed, see below ) that avoids the mentioned crasher, please consider cherry-picking to 3.5

Always ( afaict ) the code expects the index of the entry in the (maTabs) vector to correspond a tab of the same index. However the DeleteTab routine patched above will erase the entry for the tab but if that tab isn't the last tab but instead some random tab in the middle won't the order of the tabs be screwed ? We could check and only delete an entry if it is the last entry ( and otherwise make a null entry for the deleted tab ) but then we definitely would expect the code should be ready to deal with such a 'hole' (representing a sheet that no longer exists ) in the vector, that doesn't appear to be the case. Is this how it should work ? I could rework it like that if that is the intention, is it ?


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.