Re: [Libreoffice-commits] .: 2 commits - configure.in README.cross

On Thu, May 17, 2012 at 11:41:52PM -0700, Tor Lillqvist wrote:
> commit 6868d84b13a52efe91337f2dccb88e59b9f8d2b7
> Author: Tor Lillqvist <tml@iki.fi>
> Date:   Thu May 17 22:45:04 2012 +0300
>
>     Add generic --with-build-platform-configure-options
>
> diff --git a/configure.in b/configure.in
> index 9c23d8a..510d82a 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -991,6 +991,9 @@ AC_ARG_WITH(gnu-patch,
>          [Specify location of GNU patch on Solaris or FreeBSD.]),
>  ,)
>  
> +AC_ARG_WITH(build-platform-configure-options,
> +        [Specify options for the configure script run for the *build* platform in a 
> cross-compilation])
> +
>  AC_ARG_WITH(gnu-cp,
>      AS_HELP_STRING([--with-gnu-cp],
>          [Specify location of GNU cp on Solaris or FreeBSD.]),
> @@ -2021,6 +2024,7 @@ AC_ARG_WITH(macosx-version-max-allowed,
>  
>  dnl ===================================================================
>  dnl options for stuff used during cross-compilation build
> +dnl These are superseded by --with-build-platform-configure-options
>  dnl ===================================================================
>  
>  AC_ARG_WITH(system-boost-for-build,
> @@ -3472,6 +3476,7 @@ if test "$cross_compiling" = "yes"; then
>      test -n "$with_system_expat_for_build" && sub_conf_opts="$sub_conf_opts --with-system-expat"
>      test "$with_system_icu_for_build" = "yes" -o "$with_system_icu_for_build" = "force" && 
> sub_conf_opts="$sub_conf_opts --with-system-icu"
>      test -n "$with_system_libxml_for_build" && sub_conf_opts="$sub_conf_opts 
> --with-system-libxml"
> +    sub_conf_opts="$sub_conf_opts $with_build_platform_configure_options"
>      ./configure \
>          --disable-mozilla \
>          --disable-build-mozilla \

This is a good idea, but I think it would be even better to have
autogen.lastrun.build (or whatever you want to call it). Then we would
not need to specify _any_ build-specific options for the host configure.
Opinions?

D.