Re: [REVIEW-3.5] crasher fdo#45987

Markus Mohrhard <markus.mohrhard -AT- googlemail.com>
Fri, 18 May 2012 19:43:42 +0200

Hello Noel, Kohei,

I think [1] is a better patch for 3-5. I'm still not happy with it
because I had hoped that we could init the number of sheets already in
the constructor but this works only while loading a file and not when
we create an empty one. This hack is a bit dirty but was the only
useful place that already knows about the number of sheets and does
not force us to create some more ugly hacks. It just makes sure that
the number of sheets in ScViewData and ScDocument is the same.

It is a safe fix and we can include it in 3-5.

Regards,
Markus

[1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=13bb6dcddcd3e19cd97fdb28e842c778e6e093b3

Context

[REVIEW-3.5] crasher fdo#45987 · Noel Power
- Re: [REVIEW-3.5] crasher fdo#45987 · Noel Power
  - Re: [REVIEW-3.5] crasher fdo#45987 · Noel Power
    - Re: [REVIEW-3.5] crasher fdo#45987 · Kohei Yoshida
      - Re: [REVIEW-3.5] crasher fdo#45987 · Markus Mohrhard
        
        Re: [REVIEW-3.5] crasher fdo#45987 · Noel Power
        
        Re: [REVIEW-3.5] crasher fdo#45987 · Markus Mohrhard
        
        Re: [REVIEWED] [3.5] [PUSHED] crasher fdo#45987 · Kohei Yoshida
        Re: [REVIEWED] [3.5-4] crasher fdo#45987 · Noel Power
        
        Re: [PUSHED:3-5-4] crasher fdo#45987 · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.