Re: [PUSHED] Re: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- build problems fixed

Stephan Bergmann <sbergman -AT- redhat.com>
Fri, 13 Apr 2012 14:35:05 +0200

On 04/13/2012 01:39 PM, Matúš Kukan wrote:

On 13 April 2012 12:56, David Ostrovsky<david.ostrovsky@gmx.de>  wrote:

Here is the corrected patch.
I fixed the build error with --enable-werror option enabled.


Hmm, I would not push it together.
Warning errors are somehow related to gbuild because there are
different settings but I would push that separately.
I pushed one part as
http://cgit.freedesktop.org/libreoffice/core/commit/?id=99b04ed2be3023bec874fce529d453123f48ac99

The problem with this is that it needlessly leads to a -- temporarily --broken master. (Cf. Caolan's recent commits.) Pushing somethingknown-broken is also bad for bisecting.


Stephan

Context

Re: [PATCH][REVIEW] gbuild conversion: idlc module (continued)
- Re: [PATCH][REVIEW] gbuild conversion: idlc module · David Tardon
  - Re: [PATCH][REVIEW] gbuild conversion: idlc module · Matúš Kukan
  - Re: [PATCH][REVIEW] gbuild conversion: idlc module · David Ostrovsky
    - Fwd: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- problem with --enable-werror · David Ostrovsky
      - Re: Fwd: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- problem with --enable-werror · Stephan Bergmann
      - Fwd: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- build problems fixed · David Ostrovsky
        
        [PUSHED] Re: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- build problems fixed · Matúš Kukan
        
        Re: [PUSHED] Re: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- build problems fixed · David Ostrovsky
        
        Fwd: Re: [PUSHED] Re: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- build problems fixed · David Ostrovsky
        Re: Re: [PUSHED] Re: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- build problems fixed · Matúš Kukan
        
        Re: [PUSHED] Re: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- build problems fixed · Stephan Bergmann
    - [PUSHED] Re: [PATCH][REVIEW] gbuild conversion: idlc module · Matúš Kukan
- Re: [PATCH][REVIEW] gbuild conversion: idlc module · Matúš Kukan

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.