Re: [PATCH][REVIEW] gbuild conversion: idlc module

Hi David,

On 11 April 2012 23:18, David Ostrovsky <david.ostrovsky@gmx.de> wrote:
> this is gbuild conversion for idlc module.

nice

> We don't have lexer function for gbuild, so I converted dmake stuff directly
> in CustomTarget_scanner.mk.

With 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=0a45deba2be4a77db7540bd050b25bd6c26d7513
gb_CustomTarget_CustomTarget takes only one parameter.

+DESO := $(call gb_CustomTarget_get_workdir,idlc/scanner)

DESO from desktop/CustomTarget_soffice.mk is shortcut from desktop - soffice.
You should come up with unique name for a variable,
preferably 2 letters somehow derived from module and 2 from custom target.
Well, it does not really matter, this is how I was doing that, It's
just that all makefiles are
included and processed by make, so better to keep names different.

Maybe also
+   flex -o$(DESO)/scanner.cxx $(DESO)/stripped_scanner.ll
could be
+   flex -o$@ $<
so when you are changing targets somehow you can keep the rule
but that's just detail.

Otherwise it looks good.

> @Matus, thank you for your help on IRC with that.

No problem, there are also more people who would help you, you just need to ask.

Thanks,
Matus