Hi David
On 12 April 2012 23:45, David Ostrovsky <david.ostrovsky@gmx.de> wrote:
thank you for your comments on my patch. I changed it accordingly.
nice patch, thanks
I pushed it with few modifications:
- removed new_style from CustomTarget
- also removed makefile.mk from inc/
- and please, could you be consistent with tabs vs. spaces, I've
cleaned tabs from Executable_idlc.mk
But it was good.
Having said that, how could we simplify the gnu_getopt treatment in tools/Executable_rscdep.mk?
It was already done, see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=40775ce183ac29e9598cbca59e995c7e77327a1a
Thanks,
Matúš
Context
- Re: [PATCH][REVIEW] gbuild conversion: idlc module (continued)
Re: [PATCH][REVIEW] gbuild conversion: idlc module · Matúš Kukan
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.