Re: [PATCH][REVIEW] gbuild conversion: idlc module

On 12 April 2012 06:33, David Tardon <dtardon@redhat.com> wrote:
> Originally idlc is linked with salhelper too. It is possible it is no
> longer necessary, but it is also possible that it is necessary on a
> different platform.

salhelper is often needed only for Windows.

> ifeq ($(HAVE_GETOPT),YES)
>
> # nothing needed

Maybe also
$(call gb_LinkTarget_add_defs,$(1),\
    -DHAVE_GETOPT \
)
so it could be used here:
http://opengrok.libreoffice.org/xref/core/tools/Executable_rscdep.mk#59

> $(eval $(call gb_Helper_register_libraries,PLAINLIBS_NONE,\
>    gnu_getopt \
> ))

It is already registered in solenv/gbuild/platform/
This whole getopt thing is windows only (I wonder if it is still
relevant ? maybe yes)
So we need to write ifeq ($(OS),WNT) either to RepositoryExternal or
to makefiles.

Best,
Matus