Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

Hi Michael,

Michael Meeks wrote (21-02-12 13:03)
> On Tue, 2012-02-21 at 00:32 +0100, Cor Nouws wrote:
> > Just to be sure: people eligible to do reviews, are those delivering
> > code, or solely those with commit access?
>
>         I would say a competent developer, and/or someone willing to take the
> risk - that can be reduced a lot by showing impressive signs of detailed
> QA of course ;-) - you know, before/after photos of sad people with
> broken labels/then happy people with working ones etc.

[ Ah well, only one month and one day later :-\ ]

I just tested a lot of funny label sizes in combination with Winfried's 
code. Just to see what happens in case that - what I do not expect - 
something with editing the xcu file went wrong.
Of course, the results were funny size label documents, but no crash or 
other problems.
So that really looks save to me.

Furthermore: few days ago I had the pleasure to do some mail merge 
training. Forgotten to make some pictures of the students, but I can 
assure you that the people are looking forward to this improvement, 
although my work around the problem in the current 3.5 was only three or 
four steps ;-)

Oh, the most important: the labels really work fine now: no frames that 
are pushed to the next line :-)

Anything else that I could do to grow trust, so that maybe Winfrieds 
patch can make it to 3.5.3 ?

Cheers,

--
 - Cor
 - http://nl.libreoffice.org