Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Fri, Mar 16, 2012 at 3:39 AM, Winfried Donkers
<W.Donkers@dci-electronics.nl> wrote:
From: Norbert Thiebaud [mailto:nthiebaud@gmail.com]
Sent: maandag 27 februari 2012 08:26
...
yes, but the mix of various changes leading to such a big patch and
especially the removal of entry peppered in the middle of a massive
re-formating makes that, even with some diff + sed magic, I cannot
reduce that to something readable, so I cannot review it.

In order for _me_ to sign-off for 3.5 branch, I would need you to
break your patch along the lines discussed earlier...

I have done some editing with vi
-remove all leading spaces (:%s/ \{1,\}//g);
-insert linefeed between '><' (:%s/></>\r</g);
-remove empty lines (:%s/\n\{2,\}/\r/g)
on both the Labels.xcu from before and after my commit.

I made a diff file (diff -a -b), which now shows only changes in contents. The diff file is still 
7448 lines long as all 1700+ definitions have been changed.

Will this help you to review the patch for pushing to 3.5 branch?

Is the result an applicable patch ?

if so, sure send it I'll have a look

Norbert

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.