Re: [PATCH] [3.5.1 and MASTER] Fix dialog controls size and position in the file preperties dialog

Michael Stahl <mstahl -AT- redhat.com>
Tue, 28 Feb 2012 11:59:21 +0100

On 27/02/12 23:51, Riccardo Magliocchetti wrote:

Hello,

Il 27/02/2012 23:22, willubuntu ha scritto:

Hello guys,


I took also the opportunity to fix some indentation to get a consistent look
in code.


Usually is better to separate the behaviour changes from the whitespace 
cleanup othwerwise it is difficult to see what you have actually changed 
:) So if you could respin your patch fixing the bugs first it'll help 
people reviewing your code.


indeed, and that is _especially_ true if you want your fix backported to
a release branch; William, please post a no-whitespace fix for review.

regards,
 michael

Context

[PATCH] [3.5.1 and MASTER] Fix dialog controls size and position in the file preperties dialog · willubuntu
- Re: [PATCH] [3.5.1 and MASTER] Fix dialog controls size and position in the file preperties dialog · Riccardo Magliocchetti
  - Re: [PATCH] [3.5.1 and MASTER] Fix dialog controls size and position in the file preperties dialog · Ivan Timofeev
  - Re: [PATCH] [3.5.1 and MASTER] Fix dialog controls size and position in the file preperties dialog · Michael Stahl
    - Re: [PATCH] [3.5.1 and MASTER] Fix dialog controls size and position in the file preperties dialog · willubuntu
      - [PUSHED] Fix dialog controls size and position in the file preperties dialog · Michael Meeks
      - [REVIEW -3-5] Fix dialog controls size and position in the file preperties dialog · Michael Meeks
        
        Re: [PUSHED][REVIEW -3-5] Fix dialog controls size and position in the file preperties dialog · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.