Hello guys, I just finished fixing an UI bug on the file properties dialog you can find at File -> Properties...-> 'General' tab. http://libreoffice.gathoye.be/Patch_file_properties_size_and_position_0001.png I discovered that the size and positions of the buttons on this dialog weren't automatically calculated according the text they contain, which causes the following bug on some translations when the text is too large for the button. The name field is now centered according to the space size between the Bmp image and the ''Change password' button. In my code, you will see at line 841 from char 28 I added '- IMPL_EXTRA_BUTTON_WIDTH / 2 ' which seems to be useless to calculate distance between two points but this fix the following centering problem. http://libreoffice.gathoye.be/Patch_file_properties_size_and_position_0003.png I just noticed that the position given by the GetSizePos() method is mistaken on the Bmp item. When I tried to set the name field and Bmp image to the same X position as the 'Change password' button, I remarked that the Bmp image has a X position to far to the right corresponding to the IMPL_EXTRA_BUTTON_WIDTH /2. Imho the GetSizePos() method is responsible of that. Has anyone an idea? http://libreoffice.gathoye.be/Patch_file_properties_size_and_position_0002.png Results: UI bug solved screenshot (French and Dutch translations both works fine) http://nabble.documentfoundation.org/file/n3782340/0001-Fix-controls-size-and-position-on-the-document-infor.patch PATCH: 0001-Fix-controls-size-and-position-on-the-document-infor.patch I took also the opportunity to fix some indentation to get a consistent look in code. Best regards. Have a nice day. -- View this message in context: http://nabble.documentfoundation.org/PATCH-3-5-1-and-MASTER-Fix-dialog-controls-size-and-position-in-the-file-preperties-dialog-tp3782340p3782340.html Sent from the Dev mailing list archive at Nabble.com.
