Re: [PATCH] [3.5.1 and MASTER] Fix dialog controls size and position in the file preperties dialog

On 28.02.2012 02:51, Riccardo Magliocchetti wrote:
> Hello,
>
> Il 27/02/2012 23:22, willubuntu ha scritto:
> > Hello guys,
>
> > I took also the opportunity to fix some indentation to get a
> > consistent look
> > in code.
>
> Usually is better to separate the behaviour changes from the whitespace
> cleanup othwerwise it is difficult to see what you have actually changed

We have no strict rule about the whitespace at all (only about the 
indentation). So, everyone is free to use his style. And I prefer 
'foo(bar)', someone prefer 'foo( bar )'. But nobody's style is "right", 
because it is not regulated.

I would not waste the time for doing

-    if (i_bDoNotUpdateUserDefined)
+    if ( i_bDoNotUpdateUserDefined )

because:
1. One day someone will change it to the first variant. (no rules!)
2. It makes 'git blame' unusable/hard-to-use.

But, of course, you are free to format your new code or the code you are 
actually hacking in your way. ;)

Cheers,
Ivan