Re: [Libreoffice] [PUSHED-partially][PATCH]a better about dialog

Noel Power píše v Čt 02. 02. 2012 v 16:33 +0000:
> Hi Barış
>
> On 02/02/12 12:22, Noel Power wrote:
> > Hi Barış
> > looks really nice, I will push it ( or maybe someone else will before 

> So I am partially pushing the content of the patch, mostly it is 
> the same except for the width change, instead I put the links vertically 
> ( not ideal either imo ) [ see attached image ].

> Hopefully some on the list will jump in to help guide you to make it 
> more lovely ( 'afraid I'm not too much help ). Anyway, didn't want your 
> contribution to go to waste so consider this first iteration a start.
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=dde025efacba24edc700989a357c5fddbb0e4886


So the screenshot
http://lists.freedesktop.org/archives/libreoffice/attachments/20120202/d60c73ff/attachment-0001.png
looks nice and is definitely a nice step forward. I have just two
thoughts.

I would suggest to center also the build version and build id. It looks
weird when just these two lines are not centered.


Also I am not sure whether the following change is desired:

--- cut ---
- Text[ en-US ] = "This product was supplied by %OOOVENDOR.";
+ Text[ en-US ] = "%PRODUCTNAME is a free and open source office suite
developed by %OOOVENDOR. ";
--- cut ---


Note that the %OOOVENDOR might be also Red Hat, Ximian, SUSE for the
distro specific builds. They provide the build (maybe with some
modifications) but they do not develop the whole suite.

Michael, what do you think?


Best Regards,
Petr