Re: [Libreoffice] [PUSHED-partially][PATCH]a better about dialog

Hi Barış

On 02/02/12 12:22, Noel Power wrote:
> Hi Barış
> looks really nice, I will push it ( or maybe someone else will before 
> me ) when I get a build to run a quick test on this, the
now please bear in mind I am *not* by any means any sort of ui person 
but it appeared to me after looking at the detail in the patch and more 
at the image itself that changing width is not a good idea. Note: I am 
not opposed to changing the width but I think changing it with the 
present format of the dialog makes it look worse, the current version of 
the dialog more or less decides it's width based on the logo, having 
large amounts of space either side of the logo imo make it worse ( of 
course some one of those better in the know might disagree with me and 
if so they are free to say so here and re-instate that part ) My second 
reason for changing that part of your patch was that you hardcode the 
Dialog width but yet the links are presented horizontally. Now 
Libreoffice dialogs are nasty and you see sizes and positions are more 
or less hardcoded ( unless you provide some fuzzy resizing and/or pseudo 
home grown custom layouting ). Additionally because we have translations 
in so many languages it could be that in some language the hardcoded 
dialog width would not accommodate the translations of the text for the 
links. So I am partially pushing the content of the patch, mostly it is 
the same except for the width change, instead I put the links vertically 
( not ideal either imo ) [ see attached image ].
Hopefully some on the list will jump in to help guide you to make it 
more lovely ( 'afraid I'm not too much help ). Anyway, didn't want your 
contribution to go to waste so consider this first iteration a start.

http://cgit.freedesktop.org/libreoffice/core/commit/?id=dde025efacba24edc700989a357c5fddbb0e4886

thanks,

Noel

Attachment: about.png
Description: PNG image